Skip to content

fix(rspack_plugin_wasm): fix wasm [name] placeholder in runtime #11391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(rspack_plugin_wasm): fix wasm [name] placeholder in runtime #11391

wants to merge 3 commits into from

Conversation

Aszzo
Copy link

@Aszzo Aszzo commented Aug 15, 2025 •
edited
Loading

Summary

Because [name] replacement requires filename or chunkname in PathData, it is replaced at runtime by injecting placeholders (wasmModuleName)

Related links

#11351

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify Netlify
Copy link

netlify bot commented Aug 15, 2025 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit f63f2e0
🔍 Latest deploy log https://app.netlify.com/projects/rspack/deploys/689efc630baffb0008a90dac

@CLAassistant
Copy link

CLAassistant commented Aug 15, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the release: bug fix release: bug related release(mr only) label Aug 15, 2025
@chenjiahan chenjiahan requested a review from LingyuCoder August 15, 2025 02:52
chenjiahan
chenjiahan reviewed Aug 15, 2025
View reviewed changes
Copy link
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a test case to https://github.com/web-infra-dev/rspack/tree/main/packages/rspack-test-tools/tests? Thank you!

@Aszzo
Copy link
Author

Aszzo commented Aug 15, 2025 •
edited
Loading

Could you add a test case to https://github.com/web-infra-dev/rspack/tree/main/packages/rspack-test-tools/tests? Thank you!

done

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Aug 15, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #11391 will not alter performance

Comparing Aszzo:fix/wasm-runtime-wasmModuleName (f63f2e0) with main (3f007db)

🎉 Hooray! codspeed-node just leveled up to 4.0.1!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 17 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenjiahan chenjiahan chenjiahan left review comments

@LingyuCoder LingyuCoder Awaiting requested review from LingyuCoder

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
release: bug fix release: bug related release(mr only)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Aszzo @CLAassistant @chenjiahan